HyukjinKwon commented on a change in pull request #24121:
[SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string
as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266341089
##########
File path: python/pyspark/sql/functions.py
##########
@@ -48,8 +55,11 @@ def _(col):
return _
-def _create_function(name, doc=""):
- """ Create a function that takes a Column object, by name"""
+def _create_function_with_column(name, doc=""):
Review comment:
I think the classification used in this file is different. In this file, I
see, for instance, binary functions, string functions, window functions which
is closely related with SparkSQL's type, argument specification in SparkSQL, or
how it works with plans, which is defined in Scala side's SQL side.
I already described the details in the doc test. I don't see big defferences
between `_create_function_with_column`, `_create_column_function` and
`_create_function_over_column`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
