HyukjinKwon commented on a change in pull request #24121:
[SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string
as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266350558
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1450,6 +1471,8 @@ def hash(*cols):
# ---------------------- String/Binary functions ------------------------------
_string_functions = {
+ 'upper': 'Converts a string expression to upper case.',
+ 'lower': 'Converts a string expression to upper case.',
Review comment:
I mean I just intent to leave it as was before your PR.
Before your PR:
```
Help on function lower in module pyspark.sql.functions:
lower(col)
Converts a string column to lower case.
.. versionadded:: 1.5
```
After your PR:
```
Help on function lower in module pyspark.sql.functions:
lower(col)
Converts a string expression to upper case.
.. versionadded:: 1.3
(END)
```
After this PR:
```
Help on function lower in module pyspark.sql.functions:
lower(col)
Converts a string expression to upper case.
.. versionadded:: 1.5
(END)
```
Let's fix it in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
