asmello commented on a change in pull request #24121:
[SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string
as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266345163
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1450,6 +1471,8 @@ def hash(*cols):
# ---------------------- String/Binary functions ------------------------------
_string_functions = {
+ 'upper': 'Converts a string expression to upper case.',
+ 'lower': 'Converts a string expression to upper case.',
Review comment:
You mean keeping as it was after my PR or before it? Because the PR at least
made it consistent with the Scala API documentation, whereas this is a form of
regression. If the correct version is indeed 1.0, then I'd suggest either
including these functions in the `_functions_with_column` list, or creating a
separate `_string_functions` for the ones that have actually been there since
1.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
