asmello commented on a change in pull request #24121:
[SPARK-26979][PYTHON][FOLLOW-UP] Make binary math/string functions take string
as columns as well
URL: https://github.com/apache/spark/pull/24121#discussion_r266347039
##########
File path: python/pyspark/sql/functions.py
##########
@@ -48,8 +55,11 @@ def _(col):
return _
-def _create_function(name, doc=""):
- """ Create a function that takes a Column object, by name"""
+def _create_function_with_column(name, doc=""):
Review comment:
Yes, "binary functions, string functions, window functions" all are named
consistently with "column functions". But this is not only a matter of
consistency, there's actually an important difference between "with column" and
"over column". They mean different things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
