attilapiros commented on a change in pull request #24103: [SPARK-27141][YARN]
Use ConfigEntry for hardcoded configs for Yarn
URL: https://github.com/apache/spark/pull/24103#discussion_r266364364
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
##########
@@ -95,9 +96,9 @@ class YarnAllocatorSuite extends SparkFunSuite with Matchers
with BeforeAndAfter
"--class", "SomeClass")
val sparkConfClone = sparkConf.clone()
sparkConfClone
- .set("spark.executor.instances", maxExecutors.toString)
- .set("spark.executor.cores", "5")
- .set("spark.executor.memory", "2048")
+ .set(EXECUTOR_INSTANCES.key, maxExecutors.toString)
Review comment:
Why not the typesafe method used here (and in the next two lines)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
