attilapiros commented on a change in pull request #24103: [SPARK-27141][YARN]
Use ConfigEntry for hardcoded configs for Yarn
URL: https://github.com/apache/spark/pull/24103#discussion_r266539920
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
##########
@@ -394,7 +395,7 @@ class YarnAllocatorSuite extends SparkFunSuite with
Matchers with BeforeAndAfter
}
test("window based failure executor counting") {
- sparkConf.set("spark.yarn.executor.failuresValidityInterval", "100s")
+ sparkConf.set(EXECUTOR_ATTEMPT_FAILURE_VALIDITY_INTERVAL_MS, 100L)
Review comment:
I have checked the code after this line and the clock advanced in the same
way:
https://github.com/apache/spark/blob/ae205b1d8ee9bc7690205783c2bf1397f492f7b3/resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala#L418-L425
So for me using the same style within a method a bit easier to follow but of
course both works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
