cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r267297353
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala
##########
@@ -353,13 +354,15 @@ private[kafka010] class KafkaSourceProvider extends
DataSourceRegister
}
class KafkaTable(strategy: => ConsumerStrategy) extends Table
- with SupportsMicroBatchRead with SupportsContinuousRead with
SupportsStreamingWrite {
+ with SupportsRead with SupportsWrite {
Review comment:
My understanding is, the `Table` interface is the link between v2 source API
and v2 catalog API. If we want to change the abstraction later, I think that
will be very painful, moving out the read/write methods to separated interfaces
doesn't help much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
