cloud-fan commented on a change in pull request #24129: [SPARK-27190][SQL] add 
table capability for streaming
URL: https://github.com/apache/spark/pull/24129#discussion_r267320719
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/sources/v2/Table.java
 ##########
 @@ -27,11 +28,11 @@
  * implementation can be a directory on the file system, a topic of Kafka, or 
a table in the
  * catalog, etc.
  * <p>
- * This interface can mixin the following interfaces to support different 
operations, like
- * {@code SupportsRead}.
+ * This interface can mixin {@link SupportsRead} and {@link SupportsWrite} to 
provide data reading
+ * and writing ability.
  */
 @Evolving
-public interface Table {
+public interface Table extends BaseStreamingSink {
 
 Review comment:
   `BaseStreamingSink` is an empty internal interface, which is a common 
interface for v1 and v2 streaming sources. We will remove it after ds v2 is 
finalized and v1 streaming source can be removed.
   
   If we don't want to pollute the `Table` interface, we can create a
   ```
   public interface StreamingTable extends Table, BaseStreamingSink
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to