srowen commented on a change in pull request #20793:
[SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the
seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r267725594
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/clustering/PowerIterationClusteringSuite.scala
##########
@@ -48,7 +48,7 @@ class PowerIterationClusteringSuite extends SparkFunSuite
with MLlibTestSparkCon
// Generate two circles following the example in the PIC paper.
val r1 = 1.0
val n1 = 10
- val r2 = 4.0
+ val r2 = 14.0
Review comment:
I re-read the paper, and I think we probably should keep the radius of the
circle in this test. However we can increase n2, I think (actually, n2 = 10 and
n2 = 40 in the .mllib and .ml tests respectively) and also increase the number
of iterations in PIC. What about trying that? This would be less of a change to
the functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
