srowen commented on a change in pull request #20793:
[SPARK-23643][CORE][SQL][ML] Shrinking the buffer in hashSeed up to size of the
seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r267727772
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
##########
@@ -1155,31 +1161,31 @@ class LogisticRegressionSuite extends MLTest with
DefaultReadWriteTest {
coefficientsStd
5 x 1 sparse Matrix of class "dgCMatrix"
s0
- (Intercept) 0.49991996
- data.V3 -0.04131110
+ (Intercept) 0.51344133
+ data.V3 -0.04395595
data.V4 .
- data.V5 -0.08585233
- data.V6 -0.15875400
+ data.V5 -0.08699271
+ data.V6 -0.15249200
coefficients
5 x 1 sparse Matrix of class "dgCMatrix"
s0
- (Intercept) 0.5024256
+ (Intercept) 0.50936159
data.V3 .
data.V4 .
- data.V5 -0.1846038
- data.V6 -0.0559614
+ data.V5 -0.18569346
+ data.V6 -0.05625862
*/
- val coefficientsRStd = Vectors.dense(-0.04131110, 0.0, -0.08585233,
-0.15875400)
- val interceptRStd = 0.49991996
- val coefficientsR = Vectors.dense(0.0, 0.0, -0.1846038, -0.0559614)
- val interceptR = 0.5024256
+ val coefficientsRStd = Vectors.dense(-0.04395595, 0.0, -0.08699271,
-0.15249200)
+ val interceptRStd = 0.51344133
+ val coefficientsR = Vectors.dense(0.0, 0.0, -0.18569346, -0.05625862)
+ val interceptR = 0.50936159
assert(model1.intercept ~== interceptRStd relTol 6E-2)
assert(model1.coefficients ~== coefficientsRStd absTol 5E-3)
assert(model2.intercept ~== interceptR relTol 6E-3)
- assert(model2.coefficients ~= coefficientsR absTol 1E-3)
+ assert(model2.coefficients ~= coefficientsR absTol 0.05)
Review comment:
Likewise here it'd be better to not increase the tolerance, but increase the
iterations. You could double to 60, or just match the 120 in the first model
above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
