srowen commented on a change in pull request #24193:
[SPARK-27263][HistoryServer]The "Hadoop Properties" in Environment page is
coming empty for older version of event logs
URL: https://github.com/apache/spark/pull/24193#discussion_r268443669
##########
File path: core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
##########
@@ -80,9 +81,10 @@ private[ui] class EnvironmentPage(
<a>Hadoop Properties</a>
</h4>
</span>
- <div class="aggregated-hadoopProperties collapsible-table collapsed">
- {hadoopPropertiesTable}
- </div>
+ <div class="aggregated-hadoopProperties collapsible-table collapsed">
+ {hadoopPropertiesTable}
Review comment:
I think this indent change was unintentional?
I'm not sure this change is needed. Now, it is clear that there are no
properties available, rather than just making the section go missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
