srowen commented on a change in pull request #24190: [SPARK-27260][SS] Upgrade
to Kafka 2.2.0
URL: https://github.com/apache/spark/pull/24190#discussion_r268443979
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -429,7 +429,8 @@ class KafkaTestUtils(withBrokerProps: Map[String, Object]
= Map.empty) extends L
}
private def waitUntilMetadataIsPropagated(topic: String, partition: Int):
Unit = {
- def isPropagated = server.apis.metadataCache.getPartitionInfo(topic,
partition) match {
+ def isPropagated = server.dataPlaneRequestProcessor.metadataCache
Review comment:
Is `dataPlaneRequestProcessor` new in Kafka 2.2? I'm wondering how much this
causes a runtime incompatibility if someone were using an older Kafka client
library. Not that we can't do that or require it, just wondering how essential
it is. Would the current client code otherwise not work with a 2.2 broker?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
