srowen commented on a change in pull request #24219: [SPARK-27258][K8S]Deal
with the Service name that does not match regular expression
^[a-z]([-a-z0-9]*[a-z0-9])?)
URL: https://github.com/apache/spark/pull/24219#discussion_r269148680
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala
##########
@@ -38,15 +38,21 @@ private[spark] class DriverServiceFeatureStep(
s"$DRIVER_HOST_KEY is not supported in Kubernetes mode, as the driver's
hostname will be " +
"managed via a Kubernetes service.")
+ def isDigit(char: Char) : Boolean = {
+ char >= '0' && char <= '9'
+ }
+
private val preferredServiceName =
s"${kubernetesConf.resourceNamePrefix}$DRIVER_SVC_POSTFIX"
- private val resolvedServiceName = if (preferredServiceName.length <=
MAX_SERVICE_NAME_LENGTH) {
+ private val resolvedServiceName = if (preferredServiceName.length <=
MAX_SERVICE_NAME_LENGTH
+ && !isDigit(preferredServiceName.charAt(0))) {
Review comment:
This change is still wrong then. You are not checking whether the first char
is a-z.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
