squito commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r269279011
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
##########
@@ -392,13 +466,13 @@ class EventLoggingListenerSuite extends SparkFunSuite
with LocalSparkContext wit
case metricsUpdate: SparkListenerExecutorMetricsUpdate =>
case stageCompleted: SparkListenerStageCompleted =>
val execIds = Set[String]()
- (1 to 2).foreach { _ =>
+ (1 to 3).foreach { _ =>
val execId = checkStageExecutorMetrics(lines(logIdx),
stageCompleted.stageInfo.stageId, expectedMetricsEvents)
execIds += execId
logIdx += 1
}
- assert(execIds.size == 2) // check that each executor was logged
+ assert(execIds.size == 3) // check that each executor/driver was
logged
checkEvent(lines(logIdx), event)
logIdx += 1
case _ =>
Review comment:
not related to your change, but indentation is off here. Also above, there
is a missing space after the `{` in `events.foreach {event =>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
