squito commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r269280232
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
##########
@@ -274,6 +276,93 @@ class EventLoggingListenerSuite extends SparkFunSuite
with LocalSparkContext wit
val eventLogger = new EventLoggingListener(logName, None,
testDirPath.toUri(), conf)
val listenerBus = new LiveListenerBus(conf)
+ // Executor metrics
+ // driver
+ val md_1 = Array(4000L, 50L, 0L, 0L, 40L, 0L, 40L, 0L, 70L, 0L, 7500L,
3500L,
+ 0L, 0L, 0L, 0L, 10L, 90L, 2L, 20L)
+ val md_2 = Array(4500L, 50L, 0L, 0L, 40L, 0L, 40L, 0L, 70L, 0L, 8000L,
3500L,
+ 0L, 0L, 0L, 0L, 10L, 90L, 3L, 20L)
+ val md_3 = Array(4200L, 50L, 0L, 0L, 40L, 0L, 40L, 0L, 70L, 0L, 7800L,
3500L,
+ 0L, 0L, 0L, 0L, 15L, 100L, 5L, 20L)
Review comment:
this test is becoming pretty impossible to reason about . its not really
your fault, its taking something that was probably a bit too complex in the
first place, and adding to it. anyway I will think if there is a better way we
can organize this test, don't worry about it for now (unless you have a better
idea ...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
