wypoon commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r269304733
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/EventLoggingListenerSuite.scala
##########
@@ -452,6 +555,10 @@ class EventLoggingListenerSuite extends SparkFunSuite
with LocalSparkContext wit
case (expected: SparkListenerStageCompleted, actual:
SparkListenerStageCompleted) =>
// accumulables can be different, so only check the stage Id
assert(expected.stageInfo.stageId == actual.stageInfo.stageId)
+ case (expected: SparkListenerTaskEnd, actual: SparkListenerTaskEnd) =>
+ // taskInfo, taskExecutorMetrics, and taskMetrics will be different
object references,
Review comment:
I'll change the == to === in all the cases here.
I didn't want to bother checking the contents of the objects because they
are not critical or central to what we're verifying. It's just an additional
complication. Same reason we do not check the values of the accumulables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
