wypoon commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r269378096
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
##########
@@ -143,7 +143,7 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with TimeLi
execId: String,
accumUpdates: Array[(Long, Seq[AccumulatorV2[_, _]])],
blockManagerId: BlockManagerId,
- executorUpdates: ExecutorMetrics): Boolean = true
+ executorUpdates: scala.collection.Map[(Int, Int), ExecutorMetrics]):
Boolean = true
Review comment:
Your question goes to the signature in
TaskScheduler#executorHeartbeatReceived then. I guess I was used to using
java.util.Map and java.util.List in java-land, so I thought the more general
type is preferred in the signature. I used a scala.collection.Map for
executorUpdates in the case class Heartbeat, and so that percolated through.
Does it make a difference? It is true that I actually pass a mutable.Map in
the Heartbeat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
