srowen commented on a change in pull request #24212: 
[SPARK-26771][SQL][FOLLOWUP] Make all the uncache operations non-blocking by 
default
URL: https://github.com/apache/spark/pull/24212#discussion_r269508496
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala
 ##########
 @@ -93,13 +93,24 @@ class CachedTableSuite extends QueryTest with SQLTestUtils 
with SharedSQLContext
     }.sum
   }
 
+  // Blocking uncache table for tests
+  private def uncacheTable(tableName: String): Unit = {
 
 Review comment:
   My only concern is whether a user would ever need this behavior as well, but 
I think it's pretty specific to our tests. I'm OK with it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to