srowen commented on a change in pull request #24212:
[SPARK-26771][SQL][FOLLOWUP] Make all the uncache operations non-blocking by
default
URL: https://github.com/apache/spark/pull/24212#discussion_r269508140
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -2956,7 +2956,8 @@ class Dataset[T] private[sql](
* @since 1.6.0
*/
def unpersist(blocking: Boolean): this.type = {
- sparkSession.sharedState.cacheManager.uncacheQuery(this, cascade = false,
blocking)
+ sparkSession.sharedState.cacheManager.uncacheQuery(
+ sparkSession, logicalPlan, cascade = false, blocking)
Review comment:
I see, this method needs to retain a blocking param to still support this
method. OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
