cloud-fan commented on a change in pull request #24233: [SPARK-26356][SQL]
remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r269856104
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2Suite.scala
##########
@@ -367,31 +361,13 @@ class DataSourceV2Suite extends QueryTest with
SharedSQLContext {
val format = classOf[SimpleWritableDataSource].getName
val df = Seq((1L, 2L)).toDF("i", "j")
- df.write.format(format).option("path", optionPath).save()
+ df.write.format(format).option("path",
optionPath).mode("append").save()
assert(!new File(sessionPath).exists)
checkAnswer(spark.read.format(format).option("path",
optionPath).load(), df)
}
}
}
}
-
- test("SPARK-25700: do not read schema when writing in other modes except
append and overwrite") {
Review comment:
This test is not needed anymore, as `ErrorIfExists` and `Ignore` modes are
unsupported now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
