cloud-fan commented on a change in pull request #24233: [SPARK-26356][SQL]
remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r271112553
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/noop/NoopSuite.scala
##########
@@ -54,7 +56,7 @@ class NoopSuite extends SharedSQLContext {
accum.add(1)
x
}
- .write.format("noop").save()
+ .write.format("noop").mode("append").save()
Review comment:
Personally I support it, but I'd like to do it in another PR, as we expect
to have discussions about backward compatibility for changing the default mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
