srowen commented on a change in pull request #24237: [SPARK-27319][SQL] Filter
out dir based on PathFilter before listing them
URL: https://github.com/apache/spark/pull/24237#discussion_r270426293
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
##########
@@ -167,36 +167,43 @@ object InMemoryFileIndex extends Logging {
hadoopConf: Configuration,
filter: PathFilter,
sparkSession: SparkSession): Seq[(Path, Seq[FileStatus])] = {
+ // Filter out the directory before listing it leaf files
+ val filteredPaths = if (filter != null) {
+ paths.filter(filter.accept)
+ } else {
+ paths
+ }
// Short-circuits parallel listing when serial listing is likely to be
faster.
- if (paths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
- return paths.map { path =>
+ if (filteredPaths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
+ return filteredPaths.map { path =>
(path, listLeafFiles(path, hadoopConf, filter, Some(sparkSession)))
Review comment:
Rather than change it this way, should `listLeafFiles` just check if
`filter` matches `path` initially?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
