srowen commented on a change in pull request #24237: [SPARK-27319][SQL] Filter
out dir based on PathFilter before listing them
URL: https://github.com/apache/spark/pull/24237#discussion_r270427079
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
##########
@@ -167,36 +167,39 @@ object InMemoryFileIndex extends Logging {
hadoopConf: Configuration,
filter: PathFilter,
sparkSession: SparkSession): Seq[(Path, Seq[FileStatus])] = {
+ // Filter out the directory before listing it leaf files
+ val filteredPaths = paths.filter(filter.accept(_))
// Short-circuits parallel listing when serial listing is likely to be
faster.
- if (paths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
- return paths.map { path =>
+ if (filteredPaths.size <=
sparkSession.sessionState.conf.parallelPartitionDiscoveryThreshold) {
Review comment:
I see, right, it's really a filter on the full path so it doesn't matter
when you check. It won't do anything if you're filtering for
`.endsWith(".tmp")` or something and listing `/my/path`. It would change
behavior, I guess, if you happened to try to list directory `/my/path.tmp` in
this case. Now the whole thing would be filtered out, whereas the intent (I
think) and current behavior is to only match files underneath.
That's why I wonder what the use case is here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
