squito commented on a change in pull request #24245: [SPARK-13704][CORE][YARN] 
Reduce rack resolution time
URL: https://github.com/apache/spark/pull/24245#discussion_r270607872
 
 

 ##########
 File path: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClient.scala
 ##########
 @@ -83,7 +83,7 @@ private[spark] class YarnRMClient extends Logging {
       localResources: Map[String, LocalResource]): YarnAllocator = {
     require(registered, "Must register AM before creating allocator.")
     new YarnAllocator(driverUrl, driverRef, conf, sparkConf, amClient, 
appAttemptId, securityMgr,
-      localResources, new SparkRackResolver())
+      localResources, new SparkRackResolver(conf))
 
 Review comment:
   oh good point, i do want the shared instance, to use a shared 
`CachedDnsToSwitchMapping`.  In cluster mode that will make sure we re-use the 
cache.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to