squito commented on a change in pull request #24245: [SPARK-13704][CORE][YARN]
Reduce rack resolution time
URL: https://github.com/apache/spark/pull/24245#discussion_r271000464
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -1330,7 +1340,7 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
val e = new ExceptionFailure("a", "b", Array(), "c", None)
taskSetManagerSpy.handleFailedTask(taskDesc.get.taskId, TaskState.FAILED,
e)
- verify(taskSetManagerSpy, times(1)).addPendingTask(anyInt())
+ verify(taskSetManagerSpy, times(1)).addPendingTask(anyInt(), anyBoolean())
Review comment:
good point. while I like your naming more, the standard we've used in
spark is to rename it to `meq` eg.
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala#L22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
