wypoon commented on a change in pull request #23767: [SPARK-26329][CORE] Faster
polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r270609576
##########
File path: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala
##########
@@ -122,14 +124,14 @@ private[spark] class HeartbeatReceiver(sc: SparkContext,
clock: Clock)
context.reply(true)
// Messages received from executors
- case heartbeat @ Heartbeat(executorId, accumUpdates, blockManagerId,
executorMetrics) =>
+ case heartbeat @ Heartbeat(executorId, accumUpdates, blockManagerId,
executorUpdates) =>
Review comment:
The name of the field in the Heartbeat case class was changed, so it made
sense to change the variable used in this pattern matching to match the field
name.
The field used to be of type ExecutorMetrics, so the name was
executorMetrics. It is now a Map[(Int, Int), ExecutorMetrics], so I call it
executorUpdates instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
