Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3711#discussion_r22237608
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
    @@ -84,6 +86,14 @@ case class SparkListenerBlockManagerRemoved(time: Long, 
blockManagerId: BlockMan
     @DeveloperApi
     case class SparkListenerUnpersistRDD(rddId: Int) extends SparkListenerEvent
     
    +@DeveloperApi
    +case class SparkListenerExecutorAdded(executorId: String, executorInfo : 
ExecutorInfo)
    +  extends SparkListenerEvent
    +
    +@DeveloperApi
    +case class SparkListenerExecutorRemoved(executorId: String, executorInfo : 
ExecutorInfo)
    --- End diff --
    
    To re-iterate a style comment from Andrew: our style is to not place spaces 
before `:`, so this should be `executorInfo: ExecutorInfo`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to