Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3711#discussion_r22237848
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorInfo.scala ---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.scheduler.cluster
+
+import org.apache.spark.annotation.DeveloperApi
+
+/**
+ * :: DeveloperApi ::
+ * Stores information about an executor to pass from the scheduler to
SparkListeners.
+ */
+@DeveloperApi
+class ExecutorInfo(
+ val executorHost: String,
+ val totalCores: Int
+)
--- End diff --
Actually, I'll second @andrewor14's comment from the other PR: I think that
the ExecutorInfo name might be potentially confusing since we already have an
internal ExecutorInfo class. So, if you think of a better name maybe we could
change it.
@andrewor14 Regarding whether we should have a separate class or not, you
could imagine that the web UI might want to store some information on executors
for later display / lookup. By storing the executor info outside of the
message, we can just store the ExecutorInfo class. If the fields were part of
the event, then we'd have to store the events themselves or re-pack the data
into some new class that would be essentially the same as this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
