Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/3632#issuecomment-68011681
hey @markhamstra
i assume you are referring to the one method groupByKeyAndSortValues that
has an implicit Ordering[V] parameter, since the other groupByKeyAndSortValues
methods do not require an implicit Ordering to be available for the values (it
needs to be explicitly provided and is typically use-case specific and not the
natural ordering of values).
what the benefit is of an implicit conversion to a class that will have
this one method without the implicit parameter, versus a single method with an
implicit parameter? it seems to me this makes the api harder to understand. is
this for java perhaps?
i have to admit i am not sure i understand the reason for
OrderedRDDFunctions existence either (again 2 methods on PairRDDFunctions with
implicits seem preferred to me over a new class).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
