Github user koertkuipers commented on the pull request:
https://github.com/apache/spark/pull/3632#issuecomment-68081488
mhhh i dont really agree with you. i find OrderedRDD confusing because:
1) you kind of have to know that there is an implicit conversion to
OrderedRDD somewhere out there that only works in certain conditions. a method
on PairRDDFunctions with an implicit Ordering[V] parameter is part of the
public API and also very clear in the restrictions it imposes (since its
documented in the required implicit parameter that is part of the API).
2) its much harder to override the Ordering[V]. forcing the user to bring a
new implicit Ordering[V] in scope just to use it once is a somewhat bad use of
implicits (and hard to debug). an implicit parameter should allow for an
explicit override in my opinion.
anyhow, you are right that what i did does not confirm with OrderedRDD. so
if others agree with you i will rewrite it like that, no problem! good point on
the corner case of K and V having same type... let me think about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
