rdblue commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r271863798
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -578,6 +578,21 @@ namedExpressionSeq
: namedExpression (',' namedExpression)*
;
+transformList
Review comment:
We can definitely do that and you're right about being able to produce
better error messages.
Is it okay with you if we do this in a follow-up?
This PR is blocking the addition of `TableCatalog` in PR #24246, and that PR
is blocking many PRs that we can do in parallel (Select from SQL, CreateTable,
CTAS, DropTable, etc.). If we are going to get this done in time, I'd like to
get these changes in and work on improvements like this later. I'd rather have
a functional v2 implementation than friendly error messages right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
