Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3061#discussion_r22244632
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala
---
@@ -39,6 +41,10 @@ final class NioBlockTransferService(conf: SparkConf,
securityManager: SecurityMa
private var blockDataManager: BlockDataManager = _
+ private val blockFailedCounts = new HashMap[Seq[String], Int]
--- End diff --
To avoid memory leaks, we need to be sure that this won't grow without
bound. Let me try to walk through the cases...
- If no errors occur, this will remain empty since entries are only added
on error.
- If a fetch fails and a retry succeeds, then the entry is removed from
this map.
- If the maximum number of attempts is exceeded, we **don't** remove an
entry from this map.
So, looks like this adds a memory leak?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
