Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3061#discussion_r22244702
--- Diff:
core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala
---
@@ -121,8 +132,34 @@ final class NioBlockTransferService(conf: SparkConf,
securityManager: SecurityMa
}(cm.futureExecContext)
future.onFailure { case exception =>
- blockIds.foreach { blockId =>
- listener.onBlockFetchFailure(blockId, exception)
+ exception match {
+ case connectExcpt: IOException =>
--- End diff --
Why not catch `ConnectException`? I suppose it's always safe to retry as
long as the number of retries is bounded, but it's probably better to catch the
narrower exception if we're only trying to deal with connection establishment
errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
