cloud-fan commented on a change in pull request #24117: [SPARK-27181][SQL]: Add
public transform API
URL: https://github.com/apache/spark/pull/24117#discussion_r271986103
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -578,6 +578,21 @@ namedExpressionSeq
: namedExpression (',' namedExpression)*
;
+transformList
Review comment:
It's a good idea to make the parser rule general and produce a better error
message. However this is an existing problem in our parser, and it's also a
non-trivial work for this case. We need to catch `UnresolvedFunction` and valid
the arguments, the arguments can only be attributes or `ExtractValues` or
literal. I'm ok to do it in a followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
