dongjoon-hyun commented on a change in pull request #24307: [SPARK-25407][SQL]
Ensure we pass a compatible pruned schema to ParquetRowConverter
URL: https://github.com/apache/spark/pull/24307#discussion_r272802921
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
##########
@@ -322,6 +367,32 @@ private[parquet] object ParquetReadSupport {
}
}
+ /**
+ * Computes the structural intersection between two Parquet group types.
+ */
+ private def intersectParquetGroups(
+ groupType1: GroupType, groupType2: GroupType): Option[GroupType] = {
+ val fields =
+ groupType1.getFields.asScala
+ .filter(field => groupType2.containsField(field.getName))
+ .flatMap {
+ case field1: GroupType =>
+ val field2 = groupType2.getType(field1.getName)
+ if (field2.isPrimitive) {
+ None
+ } else {
+ intersectParquetGroups(field1, field2.asGroupType)
+ }
Review comment:
Ah, also, there are some line switch and indentations changes, too.
Please do diff after rebasing it. If you rebase your PR, your PR will test
against both ORC and Parquet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
