dongjoon-hyun commented on a change in pull request #24307: [SPARK-25407][SQL]
Ensure we pass a compatible pruned schema to ParquetRowConverter
URL: https://github.com/apache/spark/pull/24307#discussion_r272803558
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
##########
@@ -203,10 +204,14 @@ private[parquet] class ParquetRowConverter(
override def start(): Unit = {
var i = 0
while (i < currentRow.numFields) {
- fieldConverters(i).updater.start()
currentRow.setNullAt(i)
i += 1
}
+ i = 0
+ while (i < fieldConverters.length) {
+ fieldConverters(i).updater.start()
+ i += 1
+ }
Review comment:
@mallman . The intention of this change was a logical equivalent change to
help the reviews. Please see this final shape of the code. Do you think
something is broken here during the transformation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
