xuanyuanking commented on a change in pull request #24110: [SPARK-25341][Core] 
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24110#discussion_r272803256
 
 

 ##########
 File path: 
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
 ##########
 @@ -75,9 +77,10 @@ private[spark] class SortShuffleManager(conf: SparkConf) 
extends ShuffleManager
   }
 
   /**
-   * A mapping from shuffle ids to the number of mappers producing output for 
those shuffles.
+   * A mapping from shuffle ids to the tuple of number of mappers producing 
output and
+   * indeterminate stage attempt id for those shuffles.
    */
-  private[this] val numMapsForShuffle = new ConcurrentHashMap[Int, Int]()
+  private[this] val infoMapsForShuffle = new ConcurrentHashMap[Int, (Int, 
Option[Int])]()
 
 Review comment:
   Thanks for reminding, I'll try to create a case of 2 running map stage based 
on the description in  https://issues.apache.org/jira/browse/SPARK-7308 and 
check the behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to