xuanyuanking commented on a change in pull request #24110: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24110#discussion_r272803333
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala
##########
@@ -156,10 +162,11 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
/** Remove a shuffle's metadata from the ShuffleManager. */
override def unregisterShuffle(shuffleId: Int): Boolean = {
Review comment:
Maybe shuffle id is enough? Because only indeterminate stage has generation
id and it should be the whole stage retried by same generation id, we have kept
the tuple of the map number and the generation id in infoMapsForShuffle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
