hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-480814440 @gaborgsomogyi ` private val MAX_OFFSET_PER_TRIGGER_OPTION_KEY = "maxoffsetspertrigger"` ` val MAX_OFFSET_PER_TRIGGER = "maxOffsetsPerTrigger"` Hi, if we don't define two variables, we can use the code `if (caseInsensitiveParams.get(MAX_OFFSET_PER_TRIGGER_OPTION_KEY.toLowerCase(Locale.ROOT)).isDefined) { logWarning("maxOffsetsPerTrigger option ignored in batch queries") }` Do you have a better way?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
