vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add
multi-cluster Kafka delegation token
URL: https://github.com/apache/spark/pull/24305#discussion_r274184052
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/ConsumerStrategy.scala
##########
@@ -83,10 +86,11 @@ case class SubscribeStrategy(topics: Seq[String]) extends
ConsumerStrategy {
/**
* Use a regex to specify topics of interest.
*/
-case class SubscribePatternStrategy(topicPattern: String) extends
ConsumerStrategy {
+case class SubscribePatternStrategy(topicPattern: String,
Review comment:
These classes are technically public, but are they used by non-Spark code?
Because if they are this would be an API breakage. If they're not meant to be
used by non-Spark code, they probably should be `private[something]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
