rednaxelafx commented on issue #24352: [SPARK-27199][SQL][FOLLOWUP] Fix bug in codegen templates in UnixTime and FromUnixTime URL: https://github.com/apache/spark/pull/24352#issuecomment-482358582 Just a data point FYI: I caught this bug through visual scanning of the original PR. There were 3 occurrences of similar-looking code but one stood out being different from the other two. Upon further inspection of the other two, it was obvious that they had a bug that was fixed in the first one. Similar-looking but different code could be a trait worth checking in future code reviews.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
