rednaxelafx commented on issue #24352: [SPARK-27199][SQL][FOLLOWUP] Fix bug in codegen templates in UnixTime and FromUnixTime URL: https://github.com/apache/spark/pull/24352#issuecomment-482359690 Another idea that just popped into mind is: perhaps we can enhance `checkEvaluation` to automatically test two versions of the input expression, one that runs the input expression verbatim, the other substitutes `Literal` with `NonFoldableLiteral` to force runtime evaluation. It's not enough to test all combinations/variations, but would force exercise a lot more paths in codegen then the current test infrastructure -- we test the foldable paths in UTs much more than the non-foldable paths, because of the common pattern of using `Literal` as inputs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
