Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3795#issuecomment-68105479
To note, my suggested solution would look more like this in HashPartitioner:
```scala
def getPartition(key: Any): Int = key match {
case null => 0
case enum: Enum[_] => Utils.nonNegativeMod(enum.ordinal(),
numPartitions)
case _ => Utils.nonNegativeMod(key.hashCode, numPartitions)
}
```
This does not require reflection and Java is fast at doing instanceof
checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
