Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3795#discussion_r22548022
  
    --- Diff: 
core/src/main/scala/org/apache/spark/rdd/OrderedRDDFunctions.scala ---
    @@ -72,6 +72,8 @@ class OrderedRDDFunctions[K : Ordering : ClassTag,
        * because it can push the sorting down into the shuffle machinery.
        */
       def repartitionAndSortWithinPartitions(partitioner: Partitioner): 
RDD[(K, V)] = {
    +    val keyClass = implicitly[ClassTag[K]].runtimeClass
    +    Partitioner.assertHashCodeIsWellBehaved(keyClass)
    --- End diff --
    
    Technically, this method may work even though the hash code is not 
well-behaved, if the partitioner is not a HashPartitioner, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to