srowen commented on a change in pull request #24374: [SPARK-27366][CORE] 
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275377399
 
 

 ##########
 File path: 
core/src/test/scala/org/apache/spark/scheduler/CoarseGrainedSchedulerBackendSuite.scala
 ##########
 @@ -164,16 +170,104 @@ class CoarseGrainedSchedulerBackendSuite extends 
SparkFunSuite with LocalSparkCo
     sc.addSparkListener(listener)
 
     backend.driverEndpoint.askSync[Boolean](
-      RegisterExecutor("1", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes))
+      RegisterExecutor("1", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes, Map.empty))
     backend.driverEndpoint.askSync[Boolean](
-      RegisterExecutor("2", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes))
+      RegisterExecutor("2", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes, Map.empty))
     backend.driverEndpoint.askSync[Boolean](
-      RegisterExecutor("3", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes))
+      RegisterExecutor("3", mockEndpointRef, mockAddress.host, 1, logUrls, 
attributes, Map.empty))
 
     sc.listenerBus.waitUntilEmpty(executorUpTimeout.toMillis)
     assert(executorAddedCount === 3)
   }
 
+  test("extra gpu resources from executor") {
+    val conf = new SparkConf()
+      .set(GPUS_PER_TASK.key, "3")
+      .set(EXECUTOR_GPUS.key, "3")
+      .set(SCHEDULER_REVIVE_INTERVAL, 60000L) // don't let it auto revive 
during test
 
 Review comment:
   Does this one take value like "1m"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to