srowen commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275378237
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -210,7 +210,8 @@ class TaskSetManagerSuite extends SparkFunSuite with
LocalSparkContext with Logg
// Offer a host with NO_PREF as the constraint,
// we should get a nopref task immediately since that's what we only have
- val taskOption = manager.resourceOffer("exec1", "host1", NO_PREF)
+ val taskOption = manager.resourceOffer("exec1", "host1", NO_PREF,
ArrayBuffer.empty,
Review comment:
Should the new resources arg to resourceOffer be optional, so that not all
these callers have to pass a new empty thing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
