squito commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275606341
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -323,6 +326,7 @@ private[spark] class TaskSchedulerImpl(
maxLocality: TaskLocality,
shuffledOffers: Seq[WorkerOffer],
availableCpus: Array[Int],
+ availableGpuIndices: Array[ArrayBuffer[String]],
Review comment:
I think its confusing that we call them "Indices" but they're strings, not
ints. But then again, you also have code to check that they can parse as ints.
Can this be made consistent? I think its preferable if we really know they
are ints and can change all of the types from String to Int, and then use
`gpuIndices` consistently. But if that is not the case, also OK to instead use
`gpuAddresses` consistently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
