squito commented on a change in pull request #24374: [SPARK-27366][CORE]
Support GPU Resources in Spark job scheduling
URL: https://github.com/apache/spark/pull/24374#discussion_r275604639
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -209,7 +217,11 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
totalCoreCount.addAndGet(cores)
totalRegisteredExecutors.addAndGet(1)
val data = new ExecutorData(executorRef, executorAddress, hostname,
- cores, cores, logUrlHandler.applyPattern(logUrls, attributes),
attributes)
+ cores, cores, logUrlHandler.applyPattern(logUrls, attributes),
attributes, resources,
+ mutable.Map.empty[String, SchedulerResourceInformation] ++=
resources.mapValues(v =>
Review comment:
along the same lines -- how about removing `availableResources` from the
parameter list entirely, and just have it get created inside `ExecutorData`
from `totalResources`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
