gaborgsomogyi commented on a change in pull request #24382: [SPARK-27330][SS]
support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r275872192
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/ForeachWriter.scala
##########
@@ -139,4 +139,10 @@ abstract class ForeachWriter[T] extends Serializable {
* @param errorOrNull the error thrown during processing data or null if
there was no error.
*/
def close(errorOrNull: Throwable): Unit
+
+ /**
+ * Called when an unexpected error has raised or when the task has been
interrupted
+ * should be used in order to release resources such as connections
Review comment:
Since either `close` or `abort` or both called the second sentence is true
for `close` as well isn't it?
Nit: `Could be used to release resources such as connections.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
