gaborgsomogyi commented on a change in pull request #24382: [SPARK-27330][SS]
support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r276632875
##########
File path: docs/structured-streaming-programming-guide.md
##########
@@ -2145,6 +2145,10 @@ streamingDatasetOfString.writeStream.foreach(
def close(errorOrNull: Throwable): Unit = {
// Close the connection
}
+
+ def abort(): Unit = {
+ // Close the connection, this method is optional
Review comment:
Having 2 different functions where in one or both of them releasing
allocated resources should happen would make applications horror complicated as
a user. Having default implementation for the second function is even worse
because resources has to be released maybe in a function which is not known by
the app developer (in case of Spark upgrade most of the time devs don't analyze
through their code if it compiles and runs somehow).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
